Preparations for V8 11.x #1779
Merged
Preparations for V8 11.x #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See v8/v8@b38bf5b0. The creation context may be null for WASM objects, so the old API is deprecated in favour of GetCreationContext() which returns a MaybeLocal<Context>. However, we are not handling any WASM objects here, so we can use the version of the API that asserts that we do have a creation context.
In 11.x, it's no longer allowed to change the flags after V8 has been initialized. We can also avoid storing the string in Constants::V8_STARTUP_FLAGS, as it's no longer used anywhere else in the code base.
For the CPPGC port we'll need to use a cppgc::DefaultPlatform instead of the v8::platform::NewDefaultPlatform(). It's also harmless to use it already even if we don't use CPPGC yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains a few updates that will be required for V8 11.x but should be harmless to apply before the migration. (It should not be very risky to apply them to
main, as well.)CreationContexttoGetCreationContextChecked: theCreationContextAPI goes away in 11.x, but the replacement already exists in 10.x, so we can go ahead and use it.More details in the individual commit messages.
Does your pull request have unit tests?
No tests. The PR doesn't introduce any new functionality so the existing tests should all continue passing.